Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 99designs/keyring to v1.1.6 for go 1.15 #7398

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 25, 2020

The release contains a fix for dvsekhvalnov/jose2go#26,
which is needed for the file keyring backend to work with go 1.15.

From: #7397


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

The release contains a fix for dvsekhvalnov/jose2go#26,
which is needed for the file keyring backend to work with go 1.15.

From: #7397
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (launchpad/backports@cb23ee2). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             launchpad/backports    #7398   +/-   ##
======================================================
  Coverage                       ?   50.22%           
======================================================
  Files                          ?      338           
  Lines                          ?    17544           
  Branches                       ?        0           
======================================================
  Hits                           ?     8811           
  Misses                         ?     7945           
  Partials                       ?      788           

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alessio
Copy link
Contributor Author

alessio commented Sep 28, 2020

@clevinson Awaiting your good to go

@alessio alessio merged commit a1d18a1 into launchpad/backports Sep 28, 2020
@alessio alessio deleted the alessio/99designs-keyring-1.1.6 branch September 28, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants