Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Rosetta API into Launchpad. #7602

Closed
wants to merge 44 commits into from

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Oct 20, 2020

Description

related: #7492


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jgimeno jgimeno changed the base branch from master to launchpad/release/v0.39.2 October 20, 2020 08:14
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #7602 (4b57dbd) into launchpad/backports (2727c14) will increase coverage by 0.09%.
The diff coverage is 52.36%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           launchpad/backports    #7602      +/-   ##
=======================================================
+ Coverage                50.30%   50.40%   +0.09%     
=======================================================
  Files                      338      365      +27     
  Lines                    17572    18483     +911     
=======================================================
+ Hits                      8840     9316     +476     
- Misses                    7939     8272     +333     
- Partials                   793      895     +102     
Impacted Files Coverage Δ
server/rosetta.go 0.00% <0.00%> (ø)
server/rosetta/client/tendermint/status.go 0.00% <0.00%> (ø)
server/rosetta/construction_combine.go 0.00% <0.00%> (ø)
simapp/app.go 93.15% <ø> (ø)
server/rosetta/construction_parse.go 15.78% <15.78%> (ø)
server/rosetta/launchpad.go 21.73% <21.73%> (ø)
server/rosetta/client/sdk/tx.go 22.22% <22.22%> (ø)
server/rosetta/util.go 47.78% <47.78%> (ø)
server/rosetta/client/tendermint/block.go 48.64% <48.64%> (ø)
server/rosetta/client/tendermint/info.go 50.00% <50.00%> (ø)
... and 46 more

@jgimeno jgimeno changed the title Jonathan integrate rosetta Integrate Rosetta API into Launchpad. Oct 28, 2020
@jgimeno jgimeno mentioned this pull request Oct 28, 2020
9 tasks
@alessio alessio requested a review from alexanderbez October 28, 2020 22:31
@@ -0,0 +1,82 @@
package rosetta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this package become a top-level one? I mean: git mv server/rosetta rosetta/

@alessio alessio changed the base branch from launchpad/release/v0.39.2 to launchpad/backports November 24, 2020 10:18
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 22, 2021
@sahith-narahari
Copy link
Contributor

@jgimeno should we close this

@github-actions github-actions bot removed the stale label Jan 29, 2021
@tac0turtle
Copy link
Member

From my understanding Rosetta will only be supported on 0.42 and later. If we want to support it on launchpad, please open a new pull request

@tac0turtle tac0turtle closed this Feb 24, 2021
@alessio
Copy link
Contributor

alessio commented Feb 24, 2021

Thanks @marbar3778. Launchpad support is no longer be worked on.

@alessio alessio deleted the jonathan-integrate-rosetta branch March 14, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants