docs: fix broken urls (launchpad/backports) #7833
Conversation
lovincyrus
requested review from
alessio,
clevinson and
ethanfrey
as code owners
| @@ -103,7 +103,7 @@ Request types, which define structured interactions from users, must be defined | |||
|
|
|||
| Here is an example of a request to buy a name from the `nameservice` module: | |||
|
|
|||
| +++ https://github.com/cosmos/sdk-tutorials/blob/master/nameservice/x/nameservice/client/rest/tx.go#L14-L19 | |||
| +++ https://github.com/cosmos/cosmos-sdk/blob/7f59723d889b69ca19966167f0b3a7fec7a39e53/x/bank/client/rest/tx.go#L15-L19 | |||
There was a problem hiding this comment.
I approve of changing theblinks, using either a tag or commit hash. But could you use the same commit hash/tag in all links?
There was a problem hiding this comment.
Understood, I tried it with the same commit hash that is being used by other updated URLs but it's invalid.
Same commit hash: https://github.com/cosmos/sdk-tutorials/blob/86a27321cf89cc637581762e953d0c07f8c78ece/nameservice/x/nameservice/internal/keeper/querier.go#L19-L32
86a27321cf89cc637581762e953d0c07f8c78ece
Invalid URL with the same commit hash: https://github.com/cosmos/cosmos-sdk/blob/86a27321cf89cc637581762e953d0c07f8c78ece/x/bank/client/rest/tx.go#L15-L19
FYI: I've updated the broken links with the same links from master so they should be fine.
| @@ -149,7 +149,9 @@ The [`handler`](../building-modules/handler.md) refers to the part of the module | |||
| The `handler` of a module is generally defined in a file called `handler.go` and consists of: | |||
|
|
|||
| - A **switch function** `NewHandler` to route the message to the appropriate `handler` function. This function returns a `handler` function, and is registered in the [`AppModule`](#application-module-interface) to be used in the application's module manager to initialize the [application's router](../core/baseapp.md#routing). Next is an example of such a switch from the [nameservice tutorial](https://github.com/cosmos/sdk-tutorials/tree/master/nameservice) | |||
| +++ https://github.com/cosmos/sdk-tutorials/blob/master/nameservice/x/nameservice/handler.go#L12-L26 | |||
|
|
|||
| +++ https://github.com/cosmos/sdk-tutorials/blob/86a27321cf89cc637581762e953d0c07f8c78ece/nameservice/x/nameservice/internal/keeper/querier.go#L19-L32 | |||
There was a problem hiding this comment.
Eg this is a different commit
There was a problem hiding this comment.
Yes, that's because I'm using the updated URL from master — https://github.com/cosmos/cosmos-sdk/blame/master/docs/basics/app-anatomy.md#L209
amaury1093
added
backport/0.39.x (Launchpad)
T:Docs
fedekunze
added
the
A:automerge
|
I'm not authorized to merge. Can someone with write access merge this PR? 🙏 |
Description
Ref: cosmos/vuepress-theme-cosmos#140
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes