Add construction endpoints #7854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
jonathan/implement-account-endpoint
to
add-rosetta-master
November 9, 2020 18:41
|
This pull request introduces 1 alert when merging 5b88418 into 71608c9 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## add-rosetta-master #7854 +/- ##
===================================================
Coverage 54.17% 54.17%
===================================================
Files 611 611
Lines 38838 38838
===================================================
Hits 21040 21040
Misses 15643 15643
Partials 2155 2155 |
|
This pull request introduces 1 alert when merging a0657f8 into 71608c9 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 529f6b8 into 71608c9 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c431f61 into 71608c9 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c63707e into 71608c9 - view on LGTM.com new alerts:
|
jgimeno
reviewed
Nov 13, 2020
| // GetTransferTxDataFromOperations extracts the from and to addresses from a list of operations. | ||
| // We assume that it comes formated in the correct way. And that the balance of the sender is the same | ||
| // as the receiver operations. | ||
| func GetTransferTxDataFromOperations(ops []*types.Operation) (*banktypes.MsgSend, error) { |
There was a problem hiding this comment.
BuildMsgSendFromOperations could be more accurate.
jgimeno
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes