Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/params docs general audit & cleanup #8295

Merged
merged 6 commits into from
Jan 15, 2021
Merged

x/params docs general audit & cleanup #8295

merged 6 commits into from
Jan 15, 2021

Conversation

blushi
Copy link
Contributor

@blushi blushi commented Jan 11, 2021

Description

ref: #7659

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@blushi blushi mentioned this pull request Jan 11, 2021
Closed
17 tasks
@amaury1093 amaury1093 added the T:Docs Changes and features related to documentation. label Jan 11, 2021
@blushi blushi marked this pull request as ready for review January 13, 2021 13:53
robert-zaremba
robert-zaremba approved these changes Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blushi blushi added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 15, 2021
@mergify mergify bot merged commit 1b1dbf8 into master Jan 15, 2021
@mergify mergify bot deleted the marie/7659-x-params branch January 15, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@aleem1314 aleem1314 Awaiting requested review from aleem1314

@anilcse anilcse Awaiting requested review from anilcse

@atheeshp atheeshp Awaiting requested review from atheeshp

@clevinson clevinson Awaiting requested review from clevinson

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blushi @robert-zaremba @amaury1093