Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc : replace strings.Contains to bytes.Contains #8574

Merged

Conversation

PrathyushaLakkireddy
Copy link
Contributor

Description

closes: #8539


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #8574 (8166f87) into master (591e46f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8574   +/-   ##
=======================================
  Coverage   61.39%   61.40%           
=======================================
  Files         656      656           
  Lines       37320    37336   +16     
=======================================
+ Hits        22914    22927   +13     
- Misses      12005    12007    +2     
- Partials     2401     2402    +1     
Impacted Files Coverage Δ
x/ibc/core/02-client/keeper/grpc_query.go 76.47% <100.00%> (ø)
x/staking/keeper/validator.go 80.48% <0.00%> (-0.04%) ⬇️
x/staking/keeper/keeper.go 58.06% <0.00%> (+1.39%) ⬆️

@PrathyushaLakkireddy PrathyushaLakkireddy marked this pull request as ready for review February 12, 2021 08:29
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fedekunze fedekunze added A:automerge Automatically merge PR once all prerequisites pass. x/ibc labels Feb 12, 2021
@mergify mergify bot merged commit e4b2d75 into cosmos:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibc: use bytes.Contains instead of string.Contains where possible
3 participants