Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

fix metalinter warnings and add to CI #297

Closed
wants to merge 3 commits into from
Closed

fix metalinter warnings and add to CI #297

wants to merge 3 commits into from

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Aug 28, 2017

@adrianbrink
Copy link

I've added your remote and tried to push to it directly. But I cannot force push to it, which I have to do for the rebasing. I think as long as it's only three people developing these features, it would be great if we can all have branches on the main repo, because I always end up taking these PRs, moving them onto the main repo and then pushing them.

@odeke-em fyi

@odeke-em
Copy link
Contributor

Roger that @adrianbrink, thanks for the suggestion. I thought about that too when I saw that you had to copy a bunch of commits to a branch on the main repo.

@adrianbrink
Copy link

Do you have access to create branches on Ethermint?

@adrianbrink
Copy link

I'm closing this in favour of #298 . In the future please create branches directly on the main repo, because otherwise, we can't collaborate on features.

@zramsay
Copy link
Contributor Author

zramsay commented Aug 29, 2017

screenshot from 2017-08-29 12-23-09
we can just check ^ that box on the right hand side but yeah, sure

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants