Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

It returns error when "--chain-id" was set empty during "ethermintd init" #681

Closed
RevelationOfTuring opened this issue Dec 30, 2020 · 5 comments · Fixed by #797
Closed

Comments

@RevelationOfTuring
Copy link

System info: [Include Ethermint commit, operating system name, and other relevant details]
It says that "genesis file chain-id, if left blank will be randomly created" in ethermintd init -h
image

commit:9659b81

Steps to reproduce:

It set empty for --chaind-id :

 $ ethermintd init alice

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]
And it returns an error:

ERROR: invalid chain-id format: 

Additional info: [Include gist of relevant config, logs, etc.]

@fedekunze
Copy link
Contributor

fedekunze commented Dec 30, 2020

ah yeah the help message is from the Cosmos SDK which doesn't enforce a chain-id format. We can update the help message to require the chain-id and also the error message to be more descriptive

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Feb 14, 2021
@helder-moreira
Copy link

@fedekunze isn't it possible to make it generate a compatible chain-id by default?

@fedekunze
Copy link
Contributor

you can but it needs to have the format <chain_name>-<chain_id>

@helder-moreira
Copy link

helder-moreira commented Feb 15, 2021

It would basically require replacing this with a copy of the InitCmd with this line adapted to the right format. Am I right? Would you welcome a PR for that?

EDIT: or maybe just another wrapper on the command to generate the chain-id.

@github-actions github-actions bot removed the stale stale PRs that will be closed if no further action occurs label Feb 16, 2021
@mergify mergify bot closed this as completed in #797 Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants