init: add random chain-id generator #797

helder-moreira · 2021-02-15T15:12:19Z

Closes: #681

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze

Minor comment

types/chain_id.go

fedekunze · 2021-02-26T01:47:14Z

client/config.go

+		if chainID == "" {
+			viper.Set(flags.FlagChainID, ethermint.GenerateRandomChainID())
+		}


I'd prefer to add this logic to the ValidateChainID function

But then ValidateChainID would not just validate

helder-moreira requested a review from fedekunze February 15, 2021 15:12

helder-moreira requested a review from noot as a code owner February 15, 2021 15:12

init: add random chain-id generator

8f0ed03

helder-moreira force-pushed the helder/chain-id-generator branch from eb2c80f to 8f0ed03 Compare February 15, 2021 15:18

alessio approved these changes Feb 16, 2021

View reviewed changes

fedekunze reviewed Feb 26, 2021

View reviewed changes

fedekunze and others added 2 commits February 25, 2021 22:47

Update types/chain_id.go

2ef8f90

Merge branch 'development' into helder/chain-id-generator

95fe016

fedekunze approved these changes Feb 26, 2021

View reviewed changes

fedekunze added the automerge label Feb 26, 2021

mergify bot merged commit 99112e1 into development Feb 26, 2021

mergify bot deleted the helder/chain-id-generator branch February 26, 2021 15:50