Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Error migration #254

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Error migration #254

merged 4 commits into from
Apr 16, 2020

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Apr 15, 2020

Description

Migrates sdk.Error -> error
Reduces the surface area of changes of #183


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one comment

@fedekunze fedekunze merged commit c30205c into development Apr 16, 2020
@fedekunze fedekunze deleted the error-migration branch April 16, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants