Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

saving resivision id to store #680

Closed
wants to merge 11 commits into from

Conversation

KamiD
Copy link

@KamiD KamiD commented Dec 30, 2020

Closes: #675

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@KamiD KamiD requested review from fedekunze and noot as code owners December 30, 2020 08:28
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have some questions regarding the approach

x/evm/types/key.go Outdated Show resolved Hide resolved
x/evm/types/key.go Show resolved Hide resolved
x/evm/keeper/abci.go Outdated Show resolved Hide resolved
x/evm/keeper/abci.go Outdated Show resolved Hide resolved
x/evm/keeper/abci.go Outdated Show resolved Hide resolved
x/evm/types/statedb.go Outdated Show resolved Hide resolved
x/evm/types/statedb.go Outdated Show resolved Hide resolved
x/evm/keeper/abci.go Outdated Show resolved Hide resolved
@KamiD KamiD requested a review from fedekunze January 5, 2021 08:33
@KamiD
Copy link
Author

KamiD commented Jan 5, 2021

Thanks for the fix! I have some questions regarding the approach

I have finished change by your point, review pls~

@KamiD KamiD requested a review from fedekunze January 8, 2021 07:19
@KamiD KamiD marked this pull request as draft January 9, 2021 11:48
@ColinSchwarz ColinSchwarz added this to the Sprint 21.1.1 milestone Jan 11, 2021
@KamiD KamiD closed this Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using a wrong nextRevisionID to revert a evm call
3 participants