Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Refund gas #706

Closed
wants to merge 12 commits into from
Closed

Refund gas #706

wants to merge 12 commits into from

Conversation

AaronZgl
Copy link

@AaronZgl AaronZgl commented Jan 12, 2021

Closes: #125

Description

This pr solves the problem of gas refund. I use the SendCoinsFromModuleToAccount function of the supply module to transfer the remaining gas back to the user after K.SetLogs function in handleMsgEthereumTx and handleMsgEthermint.
After testing, in addition to the gas consumed before entering TransitionDb function and the gas consumed in EVM and the gas consumed in k.SetLogs function , all other unused gas will be returned.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Mar 18, 2021
@github-actions github-actions bot closed this Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale stale PRs that will be closed if no further action occurs Status: On Ice Type: User Reported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement transaction fee refunds
2 participants