Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Fix metamask pending while sending an error transaction #711

Merged
merged 7 commits into from
Jan 18, 2021
Merged

Fix metamask pending while sending an error transaction #711

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a1e894
Merge pull request #2 from cosmos/development
KamiD Dec 31, 2020
ae8d04f
Merge pull request #3 from cosmos/development
KamiD Jan 7, 2021
3ac7c8f
Merge pull request #4 from cosmos/development
KamiD Jan 13, 2021
4a32cf2
fix pending state in metamaks wallet when sending an error tx and rej…
KamiD Jan 13, 2021
5cd8bbd
using abci.CodeTypeOK instead 0
KamiD Jan 13, 2021
c66f42b
Merge branch 'development' into fix-mm-pending
KamiD Jan 13, 2021
fa927d5
Merge branch 'development' into fix-mm-pending
KamiD Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rpc/namespaces/eth/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@ func (api *PublicEthereumAPI) SendTransaction(args rpctypes.SendTxArgs) (common.
return common.Hash{}, err
}

if res.Code != abci.CodeTypeOK {
return common.Hash{}, fmt.Errorf(res.RawLog)
}
// Return transaction hash
return common.HexToHash(res.TxHash), nil
}
Expand Down Expand Up @@ -501,6 +504,9 @@ func (api *PublicEthereumAPI) SendRawTransaction(data hexutil.Bytes) (common.Has
return common.Hash{}, err
}

if res.Code != abci.CodeTypeOK {
return common.Hash{}, fmt.Errorf(res.RawLog)
}
// Return transaction hash
return common.HexToHash(res.TxHash), nil
}
Expand Down