Fix: reject transactions early when paid fees contain denoms unwanted #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaruwangway
requested review from
alexanderbez,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
==========================================
+ Coverage 84.11% 84.14% +0.03%
==========================================
Files 22 22
Lines 1530 1533 +3
==========================================
+ Hits 1287 1290 +3
Misses 195 195
Partials 48 48
|
mpoke
approved these changes
May 4, 2023
x/globalfee/ante/fee.go
Outdated
| @@ -73,6 +73,11 @@ func (mfd FeeDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, ne | |||
| return ctx, err | |||
| } | |||
|
|
|||
| // reject the transaction early if the feeCoins have more denoms than the fee requirement | |||
| if feeCoins.Len() > requiredGlobalFees.Len() { | |||
| return ctx, sdkerrors.Wrapf(sdkerrors.ErrInvalidCoins, "fee is not a subset of required fees; got %s, required: %s", feeCoins, requiredGlobalFees) | |||
There was a problem hiding this comment.
I think you need to use .String() for both feeCoins and requiredGlobalFees
|
Nice job @yaruwangway ! |
sainoe
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the fee antehandler to check the transaction carried fees, add the logic to reject the transaction early if the feeCoins have more denoms than the fee requirement.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change