Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ADR for introducing ICA Controller module on the Hub #2994

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

dusan-maksimovic
Copy link
Contributor

Description

This PR describes how ICA Controller will be introduced on the Hub.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for thoroughness
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
Co-authored-by: Stana Miric <[email protected]>
dusan-maksimovic and others added 2 commits March 12, 2024 15:21
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MSalopek MSalopek linked an issue Mar 18, 2024 that may be closed by this pull request
5 tasks
@mpoke
Copy link
Contributor

mpoke commented Mar 19, 2024

Add an entry to docs/docs/architecture/adr/README.md

dusan-maksimovic and others added 2 commits March 19, 2024 14:54
Co-authored-by: Marius Poke <[email protected]>
Co-authored-by: Stana Miric <[email protected]>
@dusan-maksimovic dusan-maksimovic merged commit 0b1f3d8 into main Mar 19, 2024
9 checks passed
@dusan-maksimovic dusan-maksimovic deleted the ica-controller-adr branch March 19, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Enable ICA controller
4 participants