Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Minor tweaks to README.md #917

Merged
merged 1 commit into from
Jul 30, 2021
Merged

DRAFT: Minor tweaks to README.md #917

merged 1 commit into from
Jul 30, 2021

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Jul 19, 2021

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@faddat
Copy link
Contributor

faddat commented Jul 30, 2021

yes.

@faddat
Copy link
Contributor

faddat commented Jul 30, 2021

if #924 makes state sync work properly, I also suggest that we put a quick start that uses state sync front and center on the readme file.

@alexanderbez alexanderbez merged commit 06e6f21 into main Jul 30, 2021
@alexanderbez alexanderbez deleted the okwme-patch-1 branch July 30, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants