Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix make regenerate #14

Merged
merged 2 commits into from
Oct 25, 2022
Merged

fix: fix make regenerate #14

merged 2 commits into from
Oct 25, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 10, 2022

After this PR is merged, the newly added GH workflow, will be set as required.
There is a flaky test in gogo/protobuf that is caught by CI. I have ignored it.

@julienrbrt julienrbrt marked this pull request as ready for review October 16, 2022 22:02
@julienrbrt julienrbrt requested a review from a team as a code owner October 16, 2022 22:02
@julienrbrt julienrbrt force-pushed the julien/fix-make-renegate branch from 2476661 to c74d43c Compare October 18, 2022 15:58
@julienrbrt julienrbrt enabled auto-merge (squash) October 18, 2022 16:19
@julienrbrt julienrbrt force-pushed the julien/fix-make-renegate branch from e6bb060 to f9e5895 Compare October 18, 2022 16:25
@julienrbrt julienrbrt force-pushed the julien/fix-make-renegate branch from f9e5895 to cc0ce09 Compare October 18, 2022 16:27
@julienrbrt julienrbrt mentioned this pull request Oct 25, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna approve since the size of the pr is massive and its fixing tests and some formatting

@julienrbrt julienrbrt merged commit b5eb9e6 into main Oct 25, 2022
@julienrbrt julienrbrt deleted the julien/fix-make-renegate branch October 25, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI jobs make regenerate is broken
3 participants