Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error due to empty hash when re-saving an empty version #308

Closed
erikgrinaker opened this issue Aug 24, 2020 · 0 comments · Fixed by #309
Closed

Error due to empty hash when re-saving an empty version #308

erikgrinaker opened this issue Aug 24, 2020 · 0 comments · Fixed by #309
Assignees
@erikgrinaker
Labels
T:bug Type: Bug (Confirmed)

Comments

@erikgrinaker
Copy link
Contributor

Failing test case from cosmos/cosmos-sdk#7064 indicates a problem with re-saving an old version to the same hash.

https://github.com/cosmos/cosmos-sdk/runs/993861077

--- FAIL: TestMultistoreCommitLoad (0.00s)
131
panic: version 3 was already saved to different hash E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855 (existing hash ) [recovered]
132
	panic: version 3 was already saved to different hash E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855 (existing hash )

The existing hash is returned as empty, which is surprising. It should be the hash of an empty input, i.e. E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855, and thus should not throw an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
T:bug Type: Bug (Confirmed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix re-saving old, empty versions if not changed cosmos/iavl
1 participant
@erikgrinaker