Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export: reduce node buffer to 32 #235

Merged
merged 2 commits into from
Apr 21, 2020
Merged

export: reduce node buffer to 32 #235

merged 2 commits into from
Apr 21, 2020

Conversation

erikgrinaker
Copy link
Contributor

To avoid races with IAVL pruning, the SDK must begin exports of all IAVL stores at the same time. Lowering the IAVL export buffer reduces the memory overhead of doing this, while still keeping it large enough to mitigate context switching penalties.

@erikgrinaker erikgrinaker self-assigned this Apr 21, 2020
@erikgrinaker erikgrinaker added the S:automerge Automatic merge and/or update Pull requests label Apr 21, 2020
tac0turtle
tac0turtle approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit dd2636c into master Apr 21, 2020
@mergify mergify bot deleted the erik/export-buffer-32 branch April 21, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@melekes melekes Awaiting requested review from melekes

Assignees

@erikgrinaker erikgrinaker

Labels
S:automerge Automatic merge and/or update Pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikgrinaker @tac0turtle