Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
  • Loading branch information
womensrights and coderabbitai[bot] authored May 14, 2024
1 parent 0933ce7 commit d4b9f0b
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions docs/requirements/ics27-multiplexed-requirements.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,15 @@ The current pain points for existing ICA users are listed:

- *Scalability* - When there are many interchain accounts, and many channels (in the order of 1000s), relayers struggle with the number of queries on startup and performance is compromised. Additionally, account registration being linked to the channel means that multiple packet round trips are required before your host account can execute messages.

- *Workflows requiring tokens in ICA* - there are no atomic guarantees for a workflow containing multiple applications - i.e. a token transfer followed by an ICA message. The transfer could succeed and the ICA message fail, resulting in an incomplete workflow.
- *Workflows requiring tokens in ICA* - there are no atomic guarantees for a workflow containing multiple applications - i.e. a token transfer followed by an ICA message. The transfer could succeed and the ICA message fail, resulting in an incomplete workflow.

- *Lack of default callbacks* - users are still relying on custom auth modules for packet callbacks, the callbacks middleware solves this problem but is an add-on to the application rather than a default

*Whitelisting messages* - this devex is more complicated than having a blacklist

## Objectives

Enable different account types, to be controlled remotely
- To facilitate performant cross-chain account management for accounts created on a per-user basis
Enable different account types, to be controlled remotely
- To streamline workflows using token transfer and interchain accounts in combination

Check failure on line 26 in docs/requirements/ics27-multiplexed-requirements.md

View workflow job for this annotation

GitHub Actions / lint

Lists should be surrounded by blank lines

docs/requirements/ics27-multiplexed-requirements.md:26 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- To streamline workflows usin..."] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md032.md

## Scope
Expand Down Expand Up @@ -70,7 +69,7 @@ Migration of an existing Interchain Account using a prior version of Interchain

| ID | Description | Verification | Status |
| -- | ----------- | ------------ | ------ |
| 2.01 | The controller of the interchain account must have authority over the account on the host chain to execute messages | -- | ----------- | ------------ | ------ |
| 2.01 | The controller of the interchain account must have authority over the account on the host chain to execute messages | -- | ----------- |
| 2.02 | A registered interchain account can be any account type supported by `x/accounts` | ------------ | ------ |

### 3 - Control
Expand Down

0 comments on commit d4b9f0b

Please sign in to comment.