Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GRPC API for querying counterparty address #1132

Closed
3 tasks
soareschen opened this issue Mar 16, 2022 · 0 comments · Fixed by #1224
Closed
3 tasks

Implement GRPC API for querying counterparty address #1132

soareschen opened this issue Mar 16, 2022 · 0 comments · Fixed by #1224
Assignees
@damiannolan
Labels
29-fee client-UX
Milestone
Fee middleware beta

Comments

@soareschen
Copy link

Summary

Related to #276.

When a relayer starts relaying on a channel, it needs a way to check whether it has registered its counterparty addresses on both chains so that it can be paid the receive fee. Without this API, the relayer can only blindly re-register its counterparty address before relaying which wastes transaction fees.

Proposal

Implement a GetCounterpartyAddress GRPC endpoint for the fee module.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@soareschen soareschen mentioned this issue Mar 16, 2022
Closed
5 tasks
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Mar 16, 2022
@crodriguezvega crodriguezvega added this to the Fee middleware beta milestone Mar 29, 2022
@damiannolan damiannolan moved this from Backlog to In progress in ibc-go Apr 3, 2022
@damiannolan damiannolan self-assigned this Apr 3, 2022
@crodriguezvega crodriguezvega mentioned this issue Apr 4, 2022
Closed
6 tasks
@damiannolan damiannolan mentioned this issue Apr 4, 2022
Closed
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Apr 5, 2022
@damiannolan damiannolan mentioned this issue Apr 7, 2022
Merged
9 tasks
Repository owner moved this from In review to Done in ibc-go Apr 7, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal
Use channel instead of sync cond for RetrieveLoop and blockStoreRetri… (
63486ad 
cosmos#1152)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Resolves: cosmos#1132, resolves: cosmos#1153
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee client-UX
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
3 participants
@soareschen @damiannolan @crodriguezvega