Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Successful token transfer #1963

Closed
3 tasks
chatton opened this issue Aug 10, 2022 · 0 comments · Fixed by #1973
Closed
3 tasks

E2E: Successful token transfer #1963

chatton opened this issue Aug 10, 2022 · 0 comments · Fixed by #1973
Assignees
@colin-axner
Labels
e2e
Milestone
v5.0.0

Comments

@chatton
Copy link
Contributor

chatton commented Aug 10, 2022

Summary

Add a basic E2E test which ensures a basic token transfer is successful.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton added testing Testing package and unit/integration tests ci labels Aug 10, 2022
@chatton chatton self-assigned this Aug 10, 2022
@colin-axner colin-axner assigned colin-axner and unassigned chatton Aug 10, 2022
@colin-axner colin-axner added this to the v5.0.0 milestone Aug 10, 2022
@colin-axner colin-axner mentioned this issue Aug 10, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega added e2e and removed testing Testing package and unit/integration tests labels Aug 15, 2022
@mergify mergify bot closed this as completed in #1973 Aug 15, 2022
mergify bot pushed a commit that referenced this issue Aug 15, 2022
@colin-axner
feat(test): add successful e2e transfer test (#1973)
8201ef9 
## Description



closes: #1963

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
@mergify mergify bot moved this to Done in ibc-go Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
e2e
Projects
ibc-go
Archived in project
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

feat(test): add successful e2e transfer test cosmos/ibc-go
3 participants
@crodriguezvega @chatton @colin-axner