Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Successful client recovery proposal #1965

Closed
3 tasks
colin-axner opened this issue Aug 10, 2022 · 0 comments · Fixed by #2130
Closed
3 tasks

E2E: Successful client recovery proposal #1965

colin-axner opened this issue Aug 10, 2022 · 0 comments · Fixed by #2130
Assignees
@colin-axner
Labels
02-client e2e
Milestone
v5.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Add a test which successfully updates a client using the update client proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added testing Testing package and unit/integration tests 02-client labels Aug 10, 2022
@colin-axner colin-axner added the ci label Aug 10, 2022
@crodriguezvega crodriguezvega added e2e and removed testing Testing package and unit/integration tests labels Aug 15, 2022
@colin-axner colin-axner self-assigned this Aug 15, 2022
@colin-axner colin-axner mentioned this issue Aug 15, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Aug 15, 2022
mergify bot pushed a commit that referenced this issue Aug 15, 2022
@colin-axner
e2e: add 02-client query client (#2005)
c31a19d 
## Description

Will use this functionality in addressing #1965 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
@crodriguezvega crodriguezvega added this to the v5.0.0 milestone Aug 19, 2022
@colin-axner colin-axner mentioned this issue Aug 25, 2022
Merged
9 tasks
@colin-axner colin-axner moved this from In progress to In review in ibc-go Aug 29, 2022
Repository owner moved this from In review to Done in ibc-go Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
02-client e2e
Projects
ibc-go
Archived in project
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

e2e: add client recovery proposal test cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner