Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a private function for sendTx #2239

Closed
3 tasks
colin-axner opened this issue Sep 8, 2022 · 0 comments · Fixed by #2257
Closed
3 tasks

Make a private function for sendTx #2239

colin-axner opened this issue Sep 8, 2022 · 0 comments · Fixed by #2257
Assignees
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

Add a private function sendTx which acts in a similar fashion to registerInterchainAccount, it should handle the shared legacy/new functionality and the calling functions (either legacy or message server) should do their own differentiating logic within their respective functions

For example, the legacy API should pass the absolute timestamp where the message server should pass the calculated absolute timestamp (current block time + relative timestamp)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the v6.0.0 milestone Sep 8, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Sep 8, 2022
@chatton chatton self-assigned this Sep 9, 2022
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Sep 19, 2022
Repository owner moved this from In review to Done in ibc-go Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants