Adding private sendTx function #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
==========================================
+ Coverage 79.54% 79.58% +0.04%
==========================================
Files 175 175
Lines 12069 12125 +56
==========================================
+ Hits 9600 9650 +50
- Misses 2045 2049 +4
- Partials 424 426 +2
|
chatton
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
chatton
commented
Sep 13, 2022
Comment on lines
65
to
66
| absoluteTimeout := uint64(ctx.BlockTime().UnixNano()) + msg.TimeoutTimestamp | ||
| seq, err := s.sendTx(ctx, chanCap, msg.ConnectionId, portID, msg.PacketData, absoluteTimeout) |
There was a problem hiding this comment.
I'm not 100% clear if there is more required than this change with the private function.
3 tasks
…ttps://github.com/cosmos/ibc-go into cian/issue#2239-make-a-private-function-for-sendtx
9 tasks
chatton
deleted the
cian/issue#2239-make-a-private-function-for-sendtx
branch
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
(cherry picked from commit 4297a9e)
colin-axner
added a commit
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit 4297a9e) Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: colin axnér <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2239
closes: #2241
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes