Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LogDeferred to handle errors when closing iteration #2846

Closed
3 tasks
colin-axner opened this issue Nov 29, 2022 · 1 comment · Fixed by #3021
Closed
3 tasks

Use LogDeferred to handle errors when closing iteration #2846

colin-axner opened this issue Nov 29, 2022 · 1 comment · Fixed by #3021
Assignees
@damiannolan
Labels
type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
SDK v0.47.x upgrade

Comments

@colin-axner
Copy link
Contributor

Summary

Currently we ignore any errors returned by iterator.Close(), once we update to SDK v0.47, we should utilize the newly added cosmos/cosmos-sdk#11785 LogDeferred function. I think it is fine to do all the LogDeferred additions in a single pr as the changes should be straight forward.

This change might require a version > v0.47 (I haven't checked what release the function will be in)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Nov 29, 2022
@colin-axner colin-axner moved this to Backlog in ibc-go Nov 29, 2022
@crodriguezvega
Copy link
Contributor

Looks like this will be released in v0.47 (see changelog of v0.47-alpha2). For reference, this is the PR that implemented the LogDeferred function in SDK.

@crodriguezvega crodriguezvega added this to the SDK v0.47.x upgrade milestone Dec 13, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Dec 13, 2022
@damiannolan damiannolan moved this from Todo to On hold in ibc-go Jan 2, 2023
@damiannolan damiannolan self-assigned this Jan 17, 2023
@damiannolan damiannolan mentioned this issue Jan 17, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from On hold to In progress in ibc-go Jan 17, 2023
@github-project-automation github-project-automation bot moved this from In progress to Todo in ibc-go Jan 19, 2023
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Status: Done 🥳
Milestone
SDK v0.47.x upgrade
Development

Successfully merging a pull request may close this issue.

chore: use sdk.LogDeferred when closing store iterators cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @colin-axner