Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use sdk.LogDeferred when closing store iterators #3021

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

damiannolan
Copy link
Contributor

Description

closes: #2846

Commit Message / Changelog Entry

chore: use `sdk.LogDeferred` when closing store iterators

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Sorry, something went wrong.

@damiannolan damiannolan marked this pull request as ready for review January 17, 2023 14:09
@damiannolan damiannolan enabled auto-merge (squash) January 18, 2023 10:24
@codecov-commenter
Copy link

Codecov Report

Merging #3021 (69e01c5) into main (c56f789) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
- Coverage   78.43%   78.41%   -0.02%     
==========================================
  Files         178      178              
  Lines       12338    12327      -11     
==========================================
- Hits         9677     9666      -11     
  Misses       2236     2236              
  Partials      425      425              
Impacted Files Coverage Δ
...27-interchain-accounts/controller/keeper/keeper.go 89.65% <100.00%> (-0.15%) ⬇️
...in-accounts/controller/migrations/v6/migrations.go 92.30% <100.00%> (-0.20%) ⬇️
.../apps/27-interchain-accounts/host/keeper/keeper.go 85.57% <100.00%> (-0.14%) ⬇️
modules/apps/29-fee/keeper/keeper.go 92.30% <100.00%> (-0.19%) ⬇️
modules/apps/transfer/keeper/keeper.go 91.17% <100.00%> (ø)
modules/core/02-client/keeper/keeper.go 83.26% <100.00%> (ø)
modules/core/02-client/migrations/v7/store.go 68.85% <100.00%> (ø)
modules/core/03-connection/keeper/keeper.go 90.43% <100.00%> (ø)
modules/core/04-channel/keeper/keeper.go 86.66% <100.00%> (-0.10%) ⬇️
... and 4 more

@crodriguezvega crodriguezvega merged commit 0a427c6 into main Jan 19, 2023
@crodriguezvega crodriguezvega deleted the damian/2846-log-deferred-iterators branch January 19, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use LogDeferred to handle errors when closing iteration
5 participants