Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Checker is reporting false positives #402

Closed
3 tasks
colin-axner opened this issue Sep 13, 2021 · 2 comments
Closed
3 tasks

Link Checker is reporting false positives #402

colin-axner opened this issue Sep 13, 2021 · 2 comments
Assignees
@crodriguezvega

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Sep 13, 2021 •
edited
Loading

Summary

Many of the links reported as an "error" in the link checker have a response of 429 which comes from rate limiting.

We should address this by adding a custom configuration file to retry on 429s

We could also switch to scheduled checks like tendermint

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega self-assigned this Sep 13, 2021
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Sep 13, 2021 •
edited
Loading

I also noticed this while fixing the broken links and @damiannolan pointed me to the configuration file. I have added it in the branch, but the 429 still happen, so I need to work on it a bit more.

@crodriguezvega crodriguezvega mentioned this issue Sep 16, 2021
Merged
9 tasks
@crodriguezvega
Copy link
Contributor

It has been solved in #415.

faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Add custom message handler option (cosmos#402)
4141cc3 
* Add custom message handler option

* Update changelog
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
@ilgooz
feat(relayer): make Chain.logger configurable (cosmos#402)
cb3edfc 
* feat(relayer): make Chain.logger configurable

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner