Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manually triggerable Action to build simd Docker image #2001

Merged
merged 13 commits into from
Aug 15, 2022

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Aug 12, 2022

Description

I ran into a permissions error during the e2e tests which seems to have been a result of the original images not being built on a github runner. (they had been built on my local machine). The errors only occurred when using images that were not built on a github host.

See this failure as a reference.

See this passing test which uses an image built by this workflow.

The test failures no longer occurred when the same image is built using this action instead.

Note: this workflow can be run with

gh workflow run "Build Simd Image" --ref "cian/build-image-from-tag" -f tag=v3.0.0

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@chatton chatton changed the title Manually triggerable Action to build simd Docker image Add manually triggerable Action to build simd Docker image Aug 12, 2022
Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add to the documentation for e2e the GitHub cli or UI steps needed to run this?

@chatton
Copy link
Contributor Author

chatton commented Aug 15, 2022

@crodriguezvega great suggestion I'll make an update to the e2e README

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, @chatton! Thanks for adding the section to the docs!

e2e/README.md Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
chatton and others added 6 commits August 15, 2022 12:40
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
@chatton chatton merged commit 727f0d3 into main Aug 15, 2022
@chatton chatton deleted the cian/build-image-from-tag branch August 15, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants