Add cli for MsgRegisterAccount #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anmol1696
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
puneet2019
reviewed
Aug 27, 2022
modules/apps/27-interchain-accounts/controller/client/cli/tx.go
Outdated
Show resolved
Hide resolved
puneet2019
reviewed
Aug 27, 2022
modules/apps/27-interchain-accounts/controller/client/cli/tx.go
Outdated
Show resolved
Hide resolved
puneet2019
reviewed
Aug 27, 2022
puneet2019
reviewed
Aug 27, 2022
modules/apps/27-interchain-accounts/controller/client/cli/tx.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Puneet <[email protected]>
Co-authored-by: Puneet <[email protected]>
…-go into anmol/register-account-cli
Codecov Report
@@ Coverage Diff @@
## main #2136 +/- ##
=======================================
Coverage 79.28% 79.28%
=======================================
Files 170 170
Lines 11855 11855
=======================================
Hits 9399 9399
Misses 2040 2040
Partials 416 416
|
colin-axner
approved these changes
Aug 29, 2022
modules/apps/27-interchain-accounts/controller/client/cli/tx.go
Outdated
Show resolved
Hide resolved
modules/apps/27-interchain-accounts/controller/client/cli/tx.go
Outdated
Show resolved
Hide resolved
Comment on lines
+58
to
+59
| cmd.Flags().String(flagVersion, "", "Controller chain channel version") | ||
| flags.AddTxFlagsToCmd(cmd) |
There was a problem hiding this comment.
It might be nice if we added documentation on how to create versions with ics29 enabled. Maybe in the long section
There was a problem hiding this comment.
I would be fine with doing this in a later PR when we can test everything out e2e
There was a problem hiding this comment.
Can create an issue for this and add it later too.
There was a problem hiding this comment.
Great ideas y'all. Lets open an issue
seantking
approved these changes
Aug 29, 2022
colin-axner
approved these changes
Aug 30, 2022
modules/apps/27-interchain-accounts/controller/client/cli/tx.go
Outdated
Show resolved
Hide resolved
Comment on lines
+58
to
+59
| cmd.Flags().String(flagVersion, "", "Controller chain channel version") | ||
| flags.AddTxFlagsToCmd(cmd) |
There was a problem hiding this comment.
Great ideas y'all. Lets open an issue
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
## Description Add client cmd for `MsgRegisterAccount`, similar to [inter-tx](https://github.com/cosmos/interchain-accounts-demo/blob/master/x/inter-tx/client/cli/tx.go#L36), but making appropriate changes to make it consistent with other ibc modules. ### Improvements Maybe we can better have description for the flags as well as client help/usage statements. Do let me know if we can add more clarity here. closes: #2061 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 5e78a23)
colin-axner
pushed a commit
that referenced
this pull request
Aug 31, 2022
## Description Add client cmd for `MsgRegisterAccount`, similar to [inter-tx](https://github.com/cosmos/interchain-accounts-demo/blob/master/x/inter-tx/client/cli/tx.go#L36), but making appropriate changes to make it consistent with other ibc modules. ### Improvements Maybe we can better have description for the flags as well as client help/usage statements. Do let me know if we can add more clarity here. closes: #2061 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 5e78a23) Co-authored-by: Anmol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add client cmd for
MsgRegisterAccount, similar to inter-tx, but making appropriate changes to make it consistent with other ibc modules.Improvements
Maybe we can better have description for the flags as well as client help/usage statements. Do let me know if we can add more clarity here.
closes: #2061
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes