chore: rename RegisterAccount rpc and msgs to RegisterInterchainAccount
#2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
seantking,
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
=======================================
Coverage 79.51% 79.51%
=======================================
Files 175 175
Lines 12075 12075
=======================================
Hits 9601 9601
Misses 2049 2049
Partials 425 425
|
…om:cosmos/ibc-go into damian/2230-modify-register-account-naming
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
…count` (#2253) * adding msgServer struct to ics27 controller * updating the RegisterAccount rpc and msgs to RegisterInterchainAccount, reodering fields (cherry picked from commit f8f226d) # Conflicts: # modules/apps/27-interchain-accounts/controller/client/cli/cli.go # modules/apps/27-interchain-accounts/controller/client/cli/tx.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go
This was referenced Sep 9, 2022
crodriguezvega
added a commit
that referenced
this pull request
Sep 13, 2022
…count` (backport #2253) (#2261) * chore: rename `RegisterAccount` rpc and msgs to `RegisterInterchainAccount` (#2253) * adding msgServer struct to ics27 controller * updating the RegisterAccount rpc and msgs to RegisterInterchainAccount, reodering fields (cherry picked from commit f8f226d) # Conflicts: # modules/apps/27-interchain-accounts/controller/client/cli/cli.go # modules/apps/27-interchain-accounts/controller/client/cli/tx.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go * Update tx.go * fix conflict * fix conflict * fix import Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RegisterAccountrpc toRegisterInterchainAccountMsgRegisterAccounttoMsgRegisterInterchainAccountMsgRegisterAccountResponsetoMsgRegisterInterchainAccountResponseownercomes beforeconnection_idcloses: #2230
closes: #2233
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes