Move SetMiddlewareEnabled call ordering #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-the-connection-id-instead-of-the-channel-id
…lso use connection ID
…ection-id-instead-of-the-channel-id' of https://github.com/cosmos/ibc-go into cian/issue#2235-ismiddlewareenabled-should-use-the-connection-id-instead-of-the-channel-id
…ection-id-instead-of-the-channel-id' into cian/issue#2236-move-setmiddleware-enabled-call-ordering
9 tasks
chatton
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
==========================================
+ Coverage 79.54% 79.58% +0.03%
==========================================
Files 175 175
Lines 12069 12122 +53
==========================================
+ Hits 9600 9647 +47
- Misses 2045 2049 +4
- Partials 424 426 +2
|
damiannolan
approved these changes
Sep 21, 2022
crodriguezvega
approved these changes
Sep 22, 2022
chatton
deleted the
cian/issue#2236-move-setmiddleware-enabled-call-ordering
branch
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
(cherry picked from commit 25d62f0) # Conflicts: # modules/apps/27-interchain-accounts/controller/keeper/account.go
crodriguezvega
added a commit
that referenced
this pull request
Sep 28, 2022
* Move SetMiddlewareEnabled call ordering (#2283) (cherry picked from commit 25d62f0) # Conflicts: # modules/apps/27-interchain-accounts/controller/keeper/account.go * chore: handle merge conflicts * Revert "chore: handle merge conflicts" This reverts commit 11e43da. Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: colin axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
depends on #2260closes: #2236
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes