Update CLI to recover expired client for SDK 46 updates to gov module #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmsdkeys
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
tmsdkeys
commented
Sep 16, 2022
tmsdkeys
commented
Sep 16, 2022
tmsdkeys
commented
Sep 19, 2022
Comment on lines
+92
to
+104
| { | ||
| "messages": [ | ||
| { | ||
| "@type": "/ibc.core.client.v1.ClientUpdateProposal", | ||
| "title": "title_string", | ||
| "description": "description_string", | ||
| "subject_client_id": "expired_client_id_string", | ||
| "substitute_client_id": "active_client_id_string" | ||
| } | ||
| ], | ||
| "metadata": "<metadata>", | ||
| "deposit": "10stake" | ||
| } |
There was a problem hiding this comment.
Not sure if this is correct, if anyone can review..
colin-axner
approved these changes
Sep 20, 2022
crodriguezvega
approved these changes
Sep 21, 2022
Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega
deleted the
thomas/2173-update-client-recovery-docs-sdk46
branch
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
…#2301) * Update CLI commands to recover expired client for SDK 46 updates to gov module * Fix alignment * Add proposal json, fix alginment * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit daac435) # Conflicts: # docs/ibc/proposals.md
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
…#2301) * Update CLI commands to recover expired client for SDK 46 updates to gov module * Fix alignment * Add proposal json, fix alginment * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit daac435) # Conflicts: # docs/ibc/proposals.md
colin-axner
added a commit
that referenced
this pull request
Sep 26, 2022
… (backport #2301) (#2359) * Update CLI to recover expired client for SDK 46 updates to gov module (#2301) * Update CLI commands to recover expired client for SDK 46 updates to gov module * Fix alignment * Add proposal json, fix alginment * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit daac435) # Conflicts: # docs/ibc/proposals.md * fix conflicts * remove documentation Co-authored-by: tmsdkeys <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
colin-axner
added a commit
that referenced
this pull request
Sep 26, 2022
… (backport #2301) (#2360) * Update CLI to recover expired client for SDK 46 updates to gov module (#2301) * Update CLI commands to recover expired client for SDK 46 updates to gov module * Fix alignment * Add proposal json, fix alginment * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit daac435) # Conflicts: # docs/ibc/proposals.md * fix conflicts * remove documentation Co-authored-by: tmsdkeys <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update docs on gov proposals (to recover frozen light clients) to include SDK v0.46 changes to x/gov API: https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#xgov-1
closes: #2173
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes