Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace invalid docker tag characters #2366

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Sep 21, 2022

Description

/ is not a valid docker tag character, this PR replaces any / values in git tags with - for docker tags to ensure they are valid.

this task builds an image for release/v5.0.x, the resulting tag is release-v5.0.x


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@chatton chatton merged commit 35184e1 into main Sep 22, 2022
@chatton chatton deleted the cian/fix-build-simd-task branch September 22, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants