Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing stale comment #2685

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Removing stale comment #2685

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20dfe58
chore: removing stale comment
chatton Nov 4, 2022
99f3bb5
Update modules/apps/27-interchain-accounts/controller/keeper/msg_serv…
chatton Nov 4, 2022
84f4fc5
chore: fixing indentation
chatton Nov 4, 2022
a360ba7
Merge branch 'main' into cian/issue#2676-remove-incorrect-godoc-in-ic…
crodriguezvega Nov 5, 2022
ddcac2c
Merge branch 'main' into cian/issue#2676-remove-incorrect-godoc-in-ic…
crodriguezvega Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/apps/27-interchain-accounts/controller/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ func (s msgServer) SendTx(goCtx context.Context, msg *types.MsgSendTx) (*types.M
return nil, err
}

// explicitly passing nil as the argument is discarded as the channel capability is retrieved in SendTx.
// the absolute timeout value is calculated using the controller chain block time + the relative timeout value
// this assumes time synchrony to a certain degree between the controller and counterparty host chain
absoluteTimeout := uint64(ctx.BlockTime().UnixNano()) + msg.RelativeTimeout
seq, err := s.sendTx(ctx, msg.ConnectionId, portID, msg.PacketData, absoluteTimeout)
chatton marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
Expand Down