refactor: use IterateClientStates in migration code #2857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Nov 30, 2022
| } | ||
|
|
||
| return clients, nil | ||
| func collectClients(ctx sdk.Context, keeper ClientKeeper, clientType string) (clients []string, err error) { |
There was a problem hiding this comment.
left this function as I think it is a cleaner API than IterateClientStates
|
|
||
| // collect all clients to avoid performing store state changes during iteration | ||
| defer iterator.Close() | ||
| for ; iterator.Valid(); iterator.Next() { |
…s/ibc-go into colin/2845-use-iterateclientstates
colin-axner
commented
Nov 30, 2022
| return false | ||
| }) | ||
|
|
||
| return clientIDs, nil | ||
| } | ||
|
|
||
| // removeAllClientConsensusStates removes all client consensus states from the associated |
There was a problem hiding this comment.
This function can be improved if we add a prefix to the IterateConsensusStates function
…s/ibc-go into colin/2845-use-iterateclientstates
colin-axner
commented
Nov 30, 2022
| @@ -0,0 +1,16 @@ | |||
| package tendermint | |||
There was a problem hiding this comment.
This file is only for migrations.go. I wonder if this warrants making a subdirectory migrations? And moving, expected_keepers.go, migrations.go and migrations_test.go
|
Going to split this pr up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Going to skip a changelog since this modifies unreleased code
closes: #2845
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.