Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow value with slashes in URL template #3045

Merged
merged 5 commits into from
Jan 27, 2023
Merged

fix: allow value with slashes in URL template #3045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2cde3ab
fix: allow value with slashes in URL template
crodriguezvega Jan 23, 2023
5831521
fix tests
crodriguezvega Jan 24, 2023
b32dac0
Merge branch 'main' into carlos/fix-value-with-slashes-url-template
crodriguezvega Jan 24, 2023
9449728
Merge branch 'main' into carlos/fix-value-with-slashes-url-template
crodriguezvega Jan 26, 2023
6d4939b
regenerated proto file
crodriguezvega Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 46 additions & 46 deletions modules/apps/transfer/types/query.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/apps/transfer/types/query.pb.gw.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions proto/ibc/applications/transfer/v1/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ option go_package = "github.com/cosmos/ibc-go/v7/modules/apps/transfer/types";
service Query {
// DenomTrace queries a denomination trace information.
rpc DenomTrace(QueryDenomTraceRequest) returns (QueryDenomTraceResponse) {
option (google.api.http).get = "/ibc/apps/transfer/v1/denom_traces/{hash}";
option (google.api.http).get = "/ibc/apps/transfer/v1/denom_traces/{hash=**}";
}

// DenomTraces queries all denomination traces.
Expand All @@ -28,7 +28,7 @@ service Query {

// DenomHash queries a denomination hash information.
rpc DenomHash(QueryDenomHashRequest) returns (QueryDenomHashResponse) {
option (google.api.http).get = "/ibc/apps/transfer/v1/denom_hashes/{trace}";
option (google.api.http).get = "/ibc/apps/transfer/v1/denom_hashes/{trace=**}";
}

// EscrowAddress returns the escrow address for a particular port and channel id.
Expand Down