-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version to the header #6099
feat: add version to the header #6099
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ah, sorry for updating the branch, didn't see this was in draft and have built the habbit. Feel free to roll that back if needed. |
no worries! I don't think i need to roll back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Would be fine with breaking the API in latest. We could handle that ourselves in a separate PR with the similar diffs. Either way this is testing code but we generally stick to API breaks in major versions even for our testing lib as there is a number of consumers using it.
could you please take another look? @DimitrisJim thank you! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sorry for delay! I'd assume we'd need to fix this up in main and bp up to 7.5.x @damiannolan?
Hi @ninabarbakadze, we no longer maintain our own I have taken your changes forward to the ibc-go/v7 release line in a PR here: #6180 Also should note that ibc-go/v6 is EOL |
Thanks! Can this please also be included in a v6.3.x? |
Hey @ninabarbakadze, @rootulp, I merged on Will close this PR since its stale and you're already ahead of v6.2 :) |
Description
context: celestiaorg/celestia-app#3137
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.