Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change usage of deprecated module.NewManager in SimApps #7886

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

NisTun
Copy link
Contributor

@NisTun NisTun commented Jan 27, 2025

Description

closes: #7862


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Jan 27, 2025

@NisTun, can you take a look at the failing linting? You can run the linter with:
make lint (just make sure you have at least v1.62 of golangci-lint installed)

@technicallyty, can you take a quick look at the changes and see if they are correct=

@gjermundgaraba
Copy link
Contributor

@NisTun, it looks like perhaps a CLI command got broken during this change. Can you look into that?
https://github.com/cosmos/ibc-go/actions/runs/12989065460/job/36245241734?pr=7886

simapp/app.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just want a quick approval from @technicallyty and this can be merged! :)

Copy link
Collaborator

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technicallyty technicallyty changed the title [Chore] change usage of deprecated module.NewManager in SimApps chore: change usage of deprecated module.NewManager in SimApps Jan 28, 2025
@gjermundgaraba gjermundgaraba added this pull request to the merge queue Jan 29, 2025
Merged via the queue into cosmos:main with commit 3e0a689 Jan 29, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change usage of deprecated module.NewManager in SimApps
3 participants