Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove relayer specific code and dependencies from the modules crate #154

Closed
hu55a1n1 opened this issue Oct 6, 2022 · 2 comments · Fixed by #314
Closed

Remove relayer specific code and dependencies from the modules crate #154

hu55a1n1 opened this issue Oct 6, 2022 · 2 comments · Fixed by #314
Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Oct 6, 2022

No description provided.

@plafer
Copy link
Contributor

plafer commented Oct 7, 2022

Note that this will probably be breaking (e.g. removing public items), so should be probably be done right before 1.0.0.

livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@DaviRain-Su
Merge pull request cosmos#154 from octopus-network/feature/beefy-cs
086487d 
Query and verify storage_proof of connection
@plafer plafer added the A: good-first-issue Admin: good for newcomers label Dec 13, 2022
@plafer plafer changed the title Remove relayer specific code from the modules crate Remove relayer specific code and dependencies from the modules crate Dec 13, 2022
@plafer
Copy link
Contributor

plafer commented Dec 13, 2022

Note: we should also remove unused dependencies from Cargo.toml

@Farhad-Shabani Farhad-Shabani mentioned this issue Dec 22, 2022
Merged
8 tasks
@Farhad-Shabani Farhad-Shabani added the O: code-hygiene Objective: aims to improve code hygiene label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: aims to improve code hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trim redundant code cosmos/ibc-rs
3 participants
@plafer @hu55a1n1 @Farhad-Shabani