Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientType only allows for Tendermint #188

Closed
5 tasks
plafer opened this issue Oct 19, 2022 · 0 comments
Closed
5 tasks

ClientType only allows for Tendermint #188

plafer opened this issue Oct 19, 2022 · 0 comments
Assignees
@plafer
Labels
O: new-feature Objective: aims to add new feature
Milestone
v0.21.0

Comments

@plafer
Copy link
Contributor

plafer commented Oct 19, 2022

Summary of Bug

New light clients cannot be created still because the current ClientType allows Tendermint.

Version

v0.20.0

Acceptance Criteria

ClientType is a newtype for a String, and any String is allowed internally (consistent with ibc-go).

Originates from discussion.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer added the O: new-feature Objective: aims to add new feature label Oct 19, 2022
@plafer plafer self-assigned this Oct 19, 2022
@plafer plafer added this to the v0.20.1 milestone Oct 19, 2022
@plafer plafer mentioned this issue Oct 19, 2022
Merged
7 tasks
@plafer plafer closed this as completed Oct 24, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@dependabot @crodriguezvega
chore: bump jasmine from 3.5.0 to 5.1.0 in /js (cosmos#188)
652b8a5 
Bumps [jasmine](https://github.com/jasmine/jasmine-npm) from 3.5.0 to 5.1.0.
- [Release notes](https://github.com/jasmine/jasmine-npm/releases)
- [Changelog](https://github.com/jasmine/jasmine-npm/blob/main/RELEASE.md)
- [Commits](jasmine/jasmine-npm@v3.5.0...v5.1.0)

---
updated-dependencies:
- dependency-name: jasmine
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
O: new-feature Objective: aims to add new feature
Projects
None yet
Milestone
v0.21.0
Development

No branches or pull requests
1 participant
@plafer