tendermint: box headers in Misbehaviour message #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
Coverage 64.06% 64.06%
=======================================
Files 217 217
Lines 21049 21049
=======================================
Hits 13484 13484
Misses 7565 7565 ☔ View full report in Codecov by Sentry. |
.changelog/unreleased/improvements/1145-tendermint-boxed-header.md
Outdated
Show resolved
Hide resolved
Header type is quite large. Misbehaviour holds two of those. This becomes an issue on platforms with small stack—such as Solana—where keeping (even temporary) local variable may lead to stack overflow. Fix that by Boxing each of the headers in the Misbehaviour message.
Farhad-Shabani
approved these changes
Mar 28, 2024
mina86
added a commit
to mina86/ibc-rs
that referenced
this pull request
Apr 8, 2024
Header type is quite large. Misbehaviour holds two of those. This becomes an issue on platforms with small stack—such as Solana—where keeping (even temporary) local variable may lead to stack overflow. Fix that by Boxing each of the headers in the Misbehaviour message. Co-authored-by: dhruvja <[email protected]>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
Header type is quite large. Misbehaviour holds two of those. This becomes an issue on platforms with small stack—such as Solana—where keeping (even temporary) local variable may lead to stack overflow. Fix that by Boxing each of the headers in the Misbehaviour message. Co-authored-by: dhruvja <[email protected]>
mina86
added a commit
to mina86/ibc-rs
that referenced
this pull request
Oct 4, 2024
Header type is quite large. Misbehaviour holds two of those. This becomes an issue on platforms with small stack—such as Solana—where keeping (even temporary) local variable may lead to stack overflow. Fix that by Boxing each of the headers in the Misbehaviour message. Co-authored-by: dhruvja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header type is quite large. Misbehaviour holds two of those. This becomes an issue on platforms with small stack—such as Solana—where keeping (even temporary) local variable may lead to stack overflow.
Fix that by Boxing each of the headers in the Misbehaviour message.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.