-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add into_inner()
for ICS07 ConsensusState
#1156
Conversation
…ng in check_substitute
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 63.85% 63.84% -0.01%
==========================================
Files 219 219
Lines 21359 21362 +3
==========================================
Hits 13638 13638
- Misses 7721 7724 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just a question about the removed playground link.
* chore: add into_inner() for TmConsensusState + remove redundant cloning in check_substitute * fix: markdown-lint-check * chore: add unclog * nit * fix: revert adr007 playground
Description
into_inner()
method for the ICS07ConsensusState
, so that dependent projects won't need to perform redundant cloning.check_substitute
implementation.PR author checklist:
unclog
.Reviewer checklist:
Files changed
in the GitHub PR explorer.