Add missing Tendermint client state checks #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu55a1n1
force-pushed
the
hu55a1n1/22-complete-tm-client-state-checks
branch
from
12ec9c9 to
8bf8a74
Compare
plafer
suggested changes
Oct 12, 2022
| )); | ||
| } | ||
|
|
||
| let _ = TendermintTrustThreshold::new(trust_level.numerator(), trust_level.denominator()) |
There was a problem hiding this comment.
Note there is currently a tiny bug in tendermint-rs.
There was a problem hiding this comment.
Interestingly, the spec also doesn't allow a TrustThreshold == 1 -> https://github.com/cosmos/ibc/blob/main/spec/client/ics-007-tendermint-client/README.md#client-initialisation
There was a problem hiding this comment.
Linking the spec issue -> cosmos/ibc#857
livelybug
added a commit
to octopus-network/ibc-rs
that referenced
this pull request
Oct 14, 2022
shuoer86
pushed a commit
to shuoer86/ibc-rs
that referenced
this pull request
Nov 4, 2023
Bumps [source-map-support](https://github.com/evanw/node-source-map-support) from 0.5.16 to 0.5.21. - [Release notes](https://github.com/evanw/node-source-map-support/releases) - [Commits](evanw/node-source-map-support@v0.5.16...v0.5.21) --- updated-dependencies: - dependency-name: source-map-support dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Add missing validation checks for 07-client-state * Reuse ClientState::new() for validation in TryFrom<RawClientState> * Polish error handling * Make ClientState fields private * Fix tests * Add more tests * Add changelog entry * Polish tests * Update changelog entry * Add `frozen_height` param to `ClientState::new()` * Update changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #22
Acceptance Criteria (copied from #22)
Incomplete implementation of
check_header_and_update_stateWe should add a check that incoming header's(to be addressed with 02-client-refactor Implement (parts of) ibc-go/ADR006 #173)trusted_validatorsmatches thenext_validators_hashthat was persisted in the trusted consensus stateChainIds totendermint::MaxChainID-> TM chain-id validation ibc-go#177latest_height'srevision_numbermatches theChainId'sversion.max_clock_drift.upgrade_pathmust be non-empty and this must also be checked.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.