Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(Router)!: simplify Module lookup #806

Merged
merged 6 commits into from
Aug 3, 2023
Merged

imp(Router)!: simplify Module lookup #806

merged 6 commits into from
Aug 3, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Aug 1, 2023 •
edited
Loading

Closes: #802
integration tests: informalsystems/basecoin-rs#121

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review August 1, 2023 19:25
@Farhad-Shabani Farhad-Shabani requested a review from plafer August 1, 2023 19:26
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 95.23% and no project coverage change.

Comparison is base (7191d88) 67.88% compared to head (12317a0) 67.89%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   67.88%   67.89%           
=======================================
  Files         125      125           
  Lines       14805    14803    -2     
=======================================
  Hits        10051    10051           
+ Misses       4754     4752    -2
Files Changed Coverage Δ
crates/ibc/src/core/context.rs 50.00% <0.00%> (ø)
crates/ibc/src/core/ics04_channel/error.rs 26.08% <ø> (+2.08%) ⬆️
crates/ibc/src/core/router.rs 76.40% <ø> (-4.80%) ⬇️
crates/ibc/src/core/ics04_channel/msgs.rs 94.44% <93.75%> (-5.56%) ⬇️
crates/ibc/src/core/handler.rs 92.22% <100.00%> (+0.55%) ⬆️
crates/ibc/src/mock/router.rs 90.62% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani mentioned this pull request Aug 1, 2023
Merged
plafer
plafer reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the simplification; suggested even more simplification

crates/ibc/src/core/router.rs Show resolved Hide resolved
@plafer plafer merged commit e0f2568 into main Aug 3, 2023
@plafer plafer deleted the farhad/simplify-module-lookup branch August 3, 2023 19:13
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani
imp(Router)!: simplify Module lookup (#806)
95d313f 
* imp(router): simplify Module lookup

* fix: clippy catches

* imp: discard ModuleId and use PortId::transfer everywhere instead

* Revert "imp: discard ModuleId and use PortId::transfer everywhere instead"

This reverts commit 9227ef7.

* nit: RouterError variants

* fix: cargo test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify Module lookup in the Router trait
2 participants
@Farhad-Shabani @plafer