Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: packet_commitments and packet_acknowledgements return PacketState #928

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Oct 18, 2023

Closes: #927

Description

This PR refactors QueryContext::packet_commitments and QueryContext::packet_acknowledgements to return PacketStates directly.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy requested a review from Farhad-Shabani October 18, 2023 17:05
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (476937b) 67.56% compared to head (6694374) 67.42%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   67.56%   67.42%   -0.14%     
==========================================
  Files         131      130       -1     
  Lines       16283    16316      +33     
==========================================
  Hits        11001    11001              
- Misses       5282     5315      +33     
Files Coverage Δ
crates/ibc-query/src/core/channel/query.rs 0.00% <0.00%> (ø)
crates/ibc/src/core/ics04_channel/packet.rs 36.74% <0.00%> (-10.57%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a unclog + corresponding PR in basecoin, then good to go. 🙏

@rnbguy
Copy link
Collaborator Author

rnbguy commented Oct 19, 2023

Added the changelog entry for this. Once merged, I will update the dependency rev on basecoin-rs PR.

@Farhad-Shabani Farhad-Shabani merged commit 27592c4 into main Oct 19, 2023
@Farhad-Shabani Farhad-Shabani deleted the rano/ibc_query/refactor_pkt_cmt_and_pkt_ack branch October 19, 2023 17:52
@Farhad-Shabani Farhad-Shabani added this to the v0.47.0 milestone Oct 19, 2023
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
…tState (#928)

* impl PacketState domain type

* refactor QueryContext method signatures

* update channel query methods

* add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

QueryContext::packet_commitments and QueryContext::packet_acknowledgements should return PacketState
2 participants