Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork modified cosmos-sdk modules and add them to this repo #68

Closed
1 task
mpoke opened this issue Apr 26, 2022 · 4 comments
Closed
1 task

Fork modified cosmos-sdk modules and add them to this repo #68

mpoke opened this issue Apr 26, 2022 · 4 comments
Labels
scope: cosmos-sdk Integration with Cosmos SDK

Comments

@mpoke
Copy link
Contributor

mpoke commented Apr 26, 2022 •
edited
Loading

Currently, the Interchain Security branch is https://github.com/cosmos/cosmos-sdk/tree/interchain-security-rebase

Update: #68 (comment)

Dependencies:
@mpoke mpoke moved this to Todo in Replicated Security Apr 26, 2022
@mpoke mpoke added scope: cosmos-sdk Integration with Cosmos SDK scope: testing Code review, testing, making sure the code is following the specification. labels Apr 26, 2022
@mpoke mpoke mentioned this issue Apr 27, 2022
Closed
1 task
@mpoke mpoke moved this from Todo to Next in Replicated Security May 11, 2022
@mpoke
Copy link
Contributor Author

mpoke commented May 13, 2022

After discussions within the team, we decided to not merge the Cosmos SDK changes to the master branch, but rather fork the relevant Cosmos SDK modules and add them directly to the interchain-security repo, similarly to https://github.com/iqlusioninc/liquidity-staking-module/tree/master/x

@mpoke mpoke added product and removed scope: testing Code review, testing, making sure the code is following the specification. labels May 13, 2022
@mpoke mpoke changed the title Cosmos-SDK: Open PR with Cosmos SDK changes Fork modified cosmos-sdk modules and add them to this repo May 13, 2022
@mpoke mpoke mentioned this issue May 13, 2022
Closed
@mpoke
Copy link
Contributor Author

mpoke commented Jun 8, 2022

@okwme What is the latest view on this issue? What's the preferred way to go about it?

  1. Keep own branch on cosmos-sdk, i.e., https://github.com/cosmos/cosmos-sdk/tree/interchain-security-rebase.
  2. Move the relevant SDK modules to the interchain-security repo.
  3. Merge the changes to the main SDK branch.

@mpoke mpoke added help wanted Open for all. You do not need permission to work on these. question and removed help wanted Open for all. You do not need permission to work on these. labels Jun 8, 2022
@mpoke mpoke moved this from Next to Todo in Replicated Security Aug 2, 2022
@jtremback
Copy link
Contributor

jtremback commented Sep 7, 2022 •
edited
Loading

This is settled, right @mpoke? Reopen if not.

Repository owner moved this from Todo to Done in Replicated Security Sep 7, 2022
@mpoke
Copy link
Contributor Author

mpoke commented Sep 8, 2022

Yes. The SDK changes need by IS will be merge to the main SDK branch and eventually be part of a new SDK release (e.g., 0.47). See cosmos/cosmos-sdk#13122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: cosmos-sdk Integration with Cosmos SDK
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jtremback @mpoke @sainoe