Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify proposal nomenclature #370

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Clarify proposal nomenclature #370

merged 4 commits into from
Oct 4, 2022

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Oct 4, 2022

Closes #365 on confusion around proposal nomenclature

@shaspitz shaspitz marked this pull request as ready for review October 4, 2022 18:51
@shaspitz shaspitz changed the title remove outdated confusing comments Clarify proposal nomenclature Oct 4, 2022
@shaspitz shaspitz requested a review from MSalopek October 4, 2022 18:53
Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtremback
Copy link
Contributor

Gonna force merge this because it's just some comments

@jtremback jtremback merged commit 62db93d into main Oct 4, 2022
@jtremback jtremback deleted the outdated-comments branch October 4, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor confusing function naming of Provider proposal handlers
2 participants