Chore: port ConsumerRemovalProposal handler to main
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, thanks! |
MSalopek
force-pushed
the
sainoe/consumer-removal-cli
branch
from
dc973ca to
1cf7297
Compare
|
Added integration tests. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| //#nosec G204 -- Bypass linter warning for spawning subprocess with cmd arguments. | ||
| bz, err = exec.Command("docker", "exec", tr.containerConfig.instanceName, | ||
| "/bin/bash", "-c", fmt.Sprintf(`echo '%s' > %s`, jsonStr, "/temp-proposal.json")).CombinedOutput() |
Check failure
Code scanning / CodeQL
Potentially unsafe quoting
There was a problem hiding this comment.
closed this alert, seen it before. Shouldn't matter for tests
shaspitz
reviewed
Nov 4, 2022
MSalopek
reviewed
Nov 4, 2022
| // queryConsumerChainRemoved checks if provided consumerChain | ||
| // was removed from the list of consumer chains on the provider. | ||
| // If a chain was not removed a panic will be raised. | ||
| // getConsumerChains returns a list of consumer chains that're being secured by the provider chain, |
shaspitz
approved these changes
Nov 4, 2022
jtremback
reviewed
Nov 4, 2022
| @@ -82,7 +82,7 @@ func stepsStartChains(consumerName string, setupTransferChan bool) []Step { | |||
| state: State{ | |||
| chainID("provi"): ChainState{ | |||
| Proposals: &map[uint]Proposal{ | |||
| 1: ConsumerProposal{ | |||
| 1: ConsumerAdditionProposal{ | |||
There was a problem hiding this comment.
@MSalopek great opportunity to improve these consumer chain addition tests by adding in your new ConsumerChains: &map[chainID]bool{"consu": true} state accessor!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
ConsumerRemovalProposalproposal handler and cli command from v0.1.4 to main