Key assignment related panic cleanup #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
reviewed
Jan 6, 2023
|
Nice job @smarshall-spitzbart! |
mpoke
reviewed
Jan 9, 2023
| func TMCryptoPublicKeyToConsAddr(k tmprotocrypto.PublicKey) sdk.ConsAddress { | ||
| // TMCryptoPublicKeyToConsAddr converts a TM public key to an SDK public key | ||
| // and returns the associated consensus address | ||
| func TMCryptoPublicKeyToConsAddr(k tmprotocrypto.PublicKey) (sdk.ConsAddress, error) { |
There was a problem hiding this comment.
@smarshall-spitzbart I changed this function to return error instead of panicking.
There was a problem hiding this comment.
Thanks @mpoke, looks great!
mpoke
approved these changes
Jan 9, 2023
danwt
approved these changes
Jan 9, 2023
|
Re-reviewed myself and LGTM |
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP, optionally we can audit the key related panics in
x/ccv/utils/utils.goin this PR as well.EDIT:
utils.TMCryptoPublicKeyToConsAddrshould return an error instead.Linked issues
Works toward #621
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Feature: Changes and/or adds code behavior, irrelevant to bug fixesFix: Changes and/or adds code behavior, specifically to fix a bugRefactor: Changes existing code style, naming, structure, etc.Testing: Adds testingDocs: Adds documentationRegression tests
If
Refactor, describe the new or existing tests that verify no behavior was changed or added where refactors were introduced.New behavior tests
If
FeatureorFix, describe the new or existing tests that verify the new behavior is correct and expected.